Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

description label changes on open/close #127

Open
nicolasburtey opened this issue Sep 1, 2022 · 3 comments
Open

description label changes on open/close #127

nicolasburtey opened this issue Sep 1, 2022 · 3 comments
Assignees

Comments

@nicolasburtey
Copy link
Member

when a transaction is being updated, the label changes.

  • it's "August 2022 pay..." when the sum up of the transaction is shown (we should not cut the label btw)

image

  • It's "Galoy inc payment" when the transaction is opened

image

also the fact we are changing the date format is somewhat unexpected

@nicolasburtey nicolasburtey changed the title description label changes description label changes on open/close Sep 1, 2022
@Extheoisah
Copy link
Contributor

Extheoisah commented Sep 1, 2022

@nicolasburtey I'm working on this now. I guess we should show the full description on larger screens but truncate it on smaller screens and would you like the format to be paymentDescription (settlementtype) e.g. August 2022 Payment (Galoy payment)?

@nicolasburtey
Copy link
Member Author

milli can probably provide input on the best format. not sure what her github handle is.

@daviroo
Copy link
Contributor

daviroo commented Sep 2, 2022

This is actually similar to the behaviour of the mobile app. We show friendly dates on the transaction list but if you tap on one transaction to get more details we show the full date. I think the difference is that in the mobile app it navigates you to a new screen whereas in the web wallet we are expanding the view.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants