From 1bdadaa109bb84c63769ef78a2e5fb2445ac1c69 Mon Sep 17 00:00:00 2001 From: Rishi Kumar Date: Mon, 22 Jul 2024 14:49:42 +0530 Subject: [PATCH] chore: Apt variable name and false as default --- modules/postgresql/gcp/main.tf | 2 +- modules/postgresql/gcp/variables.tf | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/postgresql/gcp/main.tf b/modules/postgresql/gcp/main.tf index 35240106..b01f2b24 100644 --- a/modules/postgresql/gcp/main.tf +++ b/modules/postgresql/gcp/main.tf @@ -21,7 +21,7 @@ resource "google_sql_database_instance" "instance" { deletion_protection_enabled = !local.destroyable dynamic "database_flags" { - for_each = local.dms_upgradable ? [{ + for_each = local.enable_logical_replication ? [{ name = "cloudsql.logical_decoding" value = "on" }, { diff --git a/modules/postgresql/gcp/variables.tf b/modules/postgresql/gcp/variables.tf index 2f93b877..2cc8bd81 100644 --- a/modules/postgresql/gcp/variables.tf +++ b/modules/postgresql/gcp/variables.tf @@ -45,10 +45,10 @@ variable "provision_read_replica" { variable "big_query_connection_location" { default = "US" } -variable "dms_upgradable" { +variable "enable_logical_replication" { description = "Instance is upgradable via Database Migration Service" type = bool - default = true + default = false } locals { @@ -66,5 +66,5 @@ locals { replication = var.replication provision_read_replica = var.provision_read_replica big_query_connection_location = var.big_query_connection_location - dms_upgradable = var.dms_upgradable + enable_logical_replication = var.enable_logical_replication }