Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distillation Towers Do Not Recognize Space in ME Hatches for void protection #17711

Open
3 tasks done
Ruling-0 opened this issue Oct 21, 2024 · 4 comments · Fixed by GTNewHorizons/GT5-Unofficial#3585 · May be fixed by GTNewHorizons/GT5-Unofficial#3594
Open
3 tasks done

Distillation Towers Do Not Recognize Space in ME Hatches for void protection #17711

Ruling-0 opened this issue Oct 21, 2024 · 4 comments · Fixed by GTNewHorizons/GT5-Unofficial#3585 · May be fixed by GTNewHorizons/GT5-Unofficial#3594
Labels
Bug: Critical Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement

Comments

@Ruling-0
Copy link

Your GTNH Discord Username

ruling_

Your Pack Version

Nightly 695

Your Server

Private Server

Java Version

Java 21

Type of Server

None

Your Expectation

The Distillation Tower / Dangote / Mega DT should recognize it has enough space in an ME output hatch to run a recipe and then run the recipe.

The Reality

If the DT is built using ME output hatches, even if they are large enough, it will refuse to run unless set to void overflow (it doesn't void anything, it does correctly place in the output). It works fine with normal output hatches.

Your Proposal

ME Output hatches should work.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Ruling-0 Ruling-0 added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Oct 21, 2024
@pilchard436
Copy link

this only occurs when you mix me output hatch with normal output hatch.

@Yoshy2002
Copy link

Yoshy2002 commented Nov 9, 2024 •
edited
Loading

Same Bug in Nightly 719. DT for Distilled Water with Me Output Hatch at 2nd Layer and Normal UHV(doesnt matter how big) Output Hatch at 3rd layer wont work, even tho the Output is only affecting the Second Layer with the ME Output Hatch.
(To reproduce)

@serenibyss serenibyss mentioned this issue Nov 30, 2024
Open
@chochem chochem changed the title Distillation Towers Do Not Recognize Space in ME Hatches Distillation Towers Do Not Recognize Space in ME Hatches for void protection Nov 30, 2024
@chochem chochem added Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 30, 2024
@serenibyss serenibyss mentioned this issue Dec 1, 2024
Merged
@Ruling-0
Copy link
Author

Ruling-0 commented Dec 2, 2024

image
image

Appears the fix has broken things further - this DTPF is producing the eternal coil hypogen recipe. After update it shut down, and only runs if void protection is on. A key thing to note is that the spacetime DTPF runs fine, leading me to believe it's an issue for recipes that output multiple fluids.

On talking on the Discord, it appears it requires 1 ME hatch per fluid in the output to function. https://discord.com/channels/181078474394566657/181078474394566657/1312961226111713320

All tested on RC2.

Reopening and flagging critical because this will now certainly break many existing setups.

@Ruling-0 Ruling-0 reopened this Dec 2, 2024
@Ruling-0
Copy link
Author

Ruling-0 commented Dec 2, 2024 •
edited
Loading

I also think even when it would run with void protection on, void protection just wasn't working.
I watched it keep running a recipe and eating all the ingredients while having no output space.

LCR subticking Phthalic, the 33ML hatch was full, it had 4 128kL hatches available, and just kept running the recipe while the 128kL did not fill.

This is also present in RC1 and just occurs if a machine has multiple ME output hatches, which probably no one has ever done before so was undocumented. Unrelated to this issue or the fix.

@serenibyss serenibyss linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Critical Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement
Projects
None yet
Milestone
No milestone
4 participants
@chochem @Ruling-0 @Yoshy2002 @pilchard436