From 6cfd11bddb95f62106abb83880cfa6ee7a245711 Mon Sep 17 00:00:00 2001 From: Bryan Alexander Date: Thu, 2 Jul 2020 14:30:16 -0500 Subject: [PATCH 1/2] adds filebase64sha256 for lambda source_code_hash --- lambda.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lambda.tf b/lambda.tf index f63e6cd..3c9897e 100644 --- a/lambda.tf +++ b/lambda.tf @@ -4,7 +4,7 @@ resource "aws_lambda_function" "lambda_function" { description = "Creates report of AWS Services in Organization accounts and saves to Excel spreadsheet in S3 bucket" role = aws_iam_role.iam_role.arn handler = "grace-inventory-lambda" - source_code_hash = filesha256(var.source_file) + source_code_hash = filebase64sha256(var.source_file) kms_key_arn = aws_kms_key.kms_key.arn runtime = "go1.x" timeout = 900 From 185d81f6767be3e9604211eb2926b5c6f24a6e89 Mon Sep 17 00:00:00 2001 From: Bryan Alexander Date: Thu, 2 Jul 2020 14:32:13 -0500 Subject: [PATCH 2/2] removes gocritic settings --- handler/.golangci.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/handler/.golangci.yml b/handler/.golangci.yml index a5238a8..5675335 100644 --- a/handler/.golangci.yml +++ b/handler/.golangci.yml @@ -24,19 +24,6 @@ linters-settings: line-length: 140 goimports: local-prefixes: github.com/golangci/golangci-lint - gocritic: - enabled-tags: - - diagnostic - - experimental - - opinionated - - performance - - style - disabled-checks: - - dupImport # https://github.com/go-critic/go-critic/issues/845 - - ifElseChain - - octalLiteral - - whyNoLint - - wrapperFunc funlen: lines: 100 statements: 50