This repository has been archived by the owner on May 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-eligibility into redirects-middleware
Pa11y testing results``` > [email protected] test:pa11y > pa11y http://localhost:3000/Welcome to Pa11y
No issues found!
|
Pa11y testing results``` > [email protected] test:pa11y > pa11y http://localhost:3000/Welcome to Pa11y
No issues found!
|
Pa11y testing results``` > [email protected] test:pa11y > pa11y http://localhost:3000/Welcome to Pa11y
No issues found!
|
scottqueen-bixal
requested review from
nehemiah-abuga,
fongcindy and
EnriqueOrt
January 17, 2024 19:46
fongcindy
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This works to update our middleware to handle redirects for the new benefit finder app located on usa.gov
Related Github Issue
Type of change
Detailed Testing steps
Since this turns our application into middleware that redirects routes to new urls, you won't be able to navigate to the pages build without being redirected.
Use the following chart to confirm our redirects are working.