Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver crash in atiogl32.dll building GLSL shaders in Godot engine 3 game #22

Open
jitspoe opened this issue Sep 3, 2024 · 9 comments
Assignees
Labels
fixed The issue has been fixed in published release OpenGL This is an issue with OpenGL driver Windows The issue is reported on Windows platform

Comments

@jitspoe
Copy link

jitspoe commented Sep 3, 2024

I made a post here:
https://community.amd.com/t5/drivers-software/driver-crash-in-atiogl32-dll-building-glsl-shaders-in-godot/td-p/701341

And was told I should report the bug here.

Original contents of post:

I don't have an ATI card, but players of my game are getting crashes while building shaders, and I've been struggling to figure out how to fix it, if I even can. I made a special build of the game that builds shaders one at a time to try to identify the problematic shader, but it isn't consistent. Different people crash on different shaders, and the same person can crash on different shaders depending on how long they wait between shader builds, so it seems to be a timer thing. The crash is in atiogl32.dll, so I'm guessing it's a driver bug.

If anybody wants to try it, the game is Fist of the Forgotten, and there's a demo on Steam. If you right click on the game in steam, go to properties, betas, then select the "debugging" build from the drop down, you can try the build that goes through the materials one at a time to see which one it crashes on.

Also, if anybody knows how to get in touch with the driver developers to report the issue, that'd be a great help!

To which goodplay replied:

OpenGL problem, post the issue at https://github.com/GPUOpen-Drivers/AMD-Gfx-Drivers

Ryzen 5 5600x, B550 aorus pro ac, Hyper 212 black, 2 x 16gb F4-3600c16dgtzn kit, NM790 2TB, Nitro+RX6900XT, RM850, Win.10 Pro., LC27G55T..

Would be awesome if we could get this fixed!

@lubaozho lubaozho self-assigned this Sep 3, 2024
@lubaozho lubaozho added Windows The issue is reported on Windows platform OpenGL This is an issue with OpenGL driver labels Sep 3, 2024
@lubaozho
Copy link
Collaborator

lubaozho commented Sep 3, 2024

@jitspoe ⁠Could you try the latest driver "24.8.1 Adrenalin release"?

@jitspoe
Copy link
Author

jitspoe commented Sep 3, 2024

I don't actually have an ATI card to test, but if somebody else has that driver and could test the demo to see if it still crashes, I'd greatly appreciate it! https://store.steampowered.com/app/1105470/Fist_of_the_Forgotten/

@Flakebi
Copy link
Member

Flakebi commented Sep 3, 2024

I can reproduce a crash with the "24.8.1 Adrenalin release" (just installed the demo from steam, didn’t use the debug build).
I’m don’t know much of OpenGL though, so I’ll leave the debugging to the experts there :)

@lubaozho
Copy link
Collaborator

lubaozho commented Sep 4, 2024

@jitspoe Thanks for reporting it, an internal bug ticket has been created to track this issue, will keep you posted on its progress. Thanks.

@jitspoe
Copy link
Author

jitspoe commented Sep 7, 2024

Thanks for taking a look at this! I've heard of other people running into crashes with Godot on AMD cards as well, though not as consistently. Hopefully this provides a nice reliable repro case to fix some of that stability as well, especially considering how popular Godot is becoming these days for building games.

@Flakebi Thanks for testing! You don't need the debug build to reproduce the crash. That one just lets you step through the shader compilation one at a time to try to identify which shader causes the problem. The results weren't consistent, though. It seemed to be more about timing than a specific shader.

@jitspoe
Copy link
Author

jitspoe commented Oct 4, 2024

Is there any way to publicly see the status of this bug?

@lubaozho
Copy link
Collaborator

Is there any way to publicly see the status of this bug?

No, I will notify you if I get any update on this.

@lubaozho
Copy link
Collaborator

@jitspoe This issue is fixed internally. The future Adrenalin driver releases will include the complete fix.

@jitspoe
Copy link
Author

jitspoe commented Nov 22, 2024

Thanks for taking care of it!

@lubaozho lubaozho added the fixed The issue has been fixed in published release label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed The issue has been fixed in published release OpenGL This is an issue with OpenGL driver Windows The issue is reported on Windows platform
Projects
None yet
Development

No branches or pull requests

3 participants