Replies: 1 comment
-
I’m not entirely sure what your returned for would be, but I say its worth a shot.
I would create two methods though:
1 - one in AnnotationEditorController that mirrors getHistoryForFeatures
2 - one in FeatureEventService that you’d proposed.
Obviously in you’d call your new method instead of your old one.
That being said, it should return functional annotation edits on the genes directly already.
That being said, it might be missing things somewhere, or maybe you mean something different (also, FYI I just found and fixed this bug #2590 <#2590>).
Nathan
… On Mar 1, 2021, at 7:57 AM, Mikkel Christensen ***@***.***> wrote:
HI Natham,
It Would be useful with a REST end point for Attributions only. The getHistoryForFeatures does give information about which annotation did the changes but also includes a lot of gene structural information and no information functional annotation.
I was thinking of modifying generateHistory in FeatureEventService (or make a new function) to return attributions for gene edits and functional edits but nothing else so it would be easy to pass. It looks to be simple but wanted to hear what you think.
Thanks for fixing the getHistoryForFeatures endpoint.
Mikkel (mbc32)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#2589>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFXNKSKJKBNSXINU6UHPBLTBO2PNANCNFSM4YMZOUHQ>.
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
HI Natham,
It Would be useful with a REST end point for Attributions only. The getHistoryForFeatures does give information about which annotation did the changes but also includes a lot of gene structural information and no information functional annotation.
I was thinking of modifying generateHistory in FeatureEventService (or make a new function) to return attributions for gene edits and functional edits but nothing else so it would be easy to pass. It looks to be simple but wanted to hear what you think.
Thanks for fixing the getHistoryForFeatures endpoint.
Mikkel (mbc32)
Beta Was this translation helpful? Give feedback.
All reactions