Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vertex markers on map drag and droppable #222

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

merydian
Copy link
Collaborator

Vertices on the map can now be dragged and dropped, a live preview is also provided.

@merydian merydian linked an issue Jan 18, 2024 that may be closed by this pull request
@merydian
Copy link
Collaborator Author

Should we add the option to toggle the live preview mode? Would lower the amount of requests.

@merydian merydian requested a review from koebi January 18, 2024 12:42
@merydian
Copy link
Collaborator Author

Integrate option to use custom provider with this.

@koebi
Copy link
Collaborator

koebi commented Jan 26, 2024

Hey,
I played around with this a bit, and it's definitely going into a great direction.

My main issue is, however, that there is no indication that points can be dragged - no "edit"-like button, and no change of mouse pointer when hovering over the map.

There were a few minor issues:

  1. Dragging points isn't very visual - the new point only shows up when I release the mouse button.
  2. Dragged points show up as new numbers in the list - > list says 1, 2, 3, 1, 2, 3, 4, 5, 6
  3. Dragged points seem to get duplicated?
  4. Trying to mark multiple points for deletion via shift-click (as you do in other GUIs) leads to QGIS crashing after some time :(

@koebi
Copy link
Collaborator

koebi commented Jan 26, 2024

Should we add the option to toggle the live preview mode? Would lower the amount of requests.

I would even suggest making this the default. It's quite confusing that routes get auto-generated if you're not ready for it ;)

@merydian merydian marked this pull request as ready for review February 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make vertex markers on map drag and droppable
2 participants