Consolidate local/prod nginx conf & deploy scripts

[tristan-orourke]

Split off from #2834

We now have two nearly ngnix config files: infrastructure/conf/nginx-conf-deploy/default and infrastructure/conf/nginx-conf-local/default. The former is used by Azure DevOps, the latter by our local dev Docker container. It would be preferable to maintain only a single file. (We could use ENV:APP_ENV as a condition for certain rewrites if we only want them available locally.)

Screenshot

Possible Implementation

• The setup.sh script could could add debugging lines to a base file
• The post_deploy.sh script could remove debugging lines from a base file (probably less safe)

Acceptance Criteria

• A single Nginx conf file works as a base for routing both locally and in Azure

[patcon]

Suggested first-step, collapse all our htaccess into one file. This aligned with what needs to happen for nginx (which has no concept of per-folder config)
re: todos in #3560

EDIT: Discussed in backlog grooming (tristan, vachan, brinda, patcon), and realized that this is best left to another issue.

[mnigh]

@GCTC-NTGC/developers is there still interest in moving ahead with this issue? the two files seem to have quite a few differences between them.

Screenshot

[esizer]

@GCTC-NTGC/developers is there still interest in moving ahead with this issue? the two files seem to have quite a few differences between them.

Since we do need different configs (i think) I don't think we can get away with having only one file. But, we could have a common file so we don't need to duplicate similar definitions and then use include to add the additional items for each env.

[tristan-orourke]

Looks like the differences are...

• enable logging on local
• never cache locally
• a few cases of hardcoding locally when we could use an env variable instead
• extra blocks for local auth, phpinfo and xdebuginfo

[tristan-orourke]

Is it really necessary to never cache locally? Especially if we keep cache times reasonably short, eg 1 minute.

I like @esizer's suggestion of a comment file and include statements for the extra blocks. Would be easier if we referenced env variables on local in the same places we do in the prod script.

[petertgiles]

I'd like to continue to keep them separate. They're never going to match exactly and as long as the two files live close together it's easy enough to diff them and make sure they don't drift apart. If we start dynamically building them it will just make it harder to read and manage them.

[tristan-orourke]

Fair enough.
Closed for: wise words from @petertgiles