Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debt] Split up e2e tests #12392

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Debt] Split up e2e tests #12392

wants to merge 8 commits into from

Conversation

esizer
Copy link
Member

@esizer esizer commented Dec 30, 2024 •
edited
Loading

🤖 Resolves #12357

👋 Introduction

Splits up slow playwright tests to hopefully better leverage shards.

🧪 Testing

  1. Confirm tests pass
  2. Confirm no loss in coverage

@esizer esizer marked this pull request as ready for review December 30, 2024 19:20
@vd1992 vd1992 self-requested a review January 6, 2025 19:14
vd1992
vd1992 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@vd1992 vd1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to look good to me!

Still see some slow test logging but some of those tests really can't be split without becoming ugly so oh well. Flakiness in the CI and local, but that is nothing new 😛

@tristan-orourke tristan-orourke self-requested a review January 7, 2025 16:15
@mnigh mnigh self-requested a review January 7, 2025 18:15
mnigh
mnigh approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vd1992 vd1992 vd1992 approved these changes

@mnigh mnigh mnigh approved these changes

@tristan-orourke tristan-orourke Awaiting requested review from tristan-orourke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Address slow playwright tests
3 participants
@esizer @mnigh @vd1992