Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Card repeater action item labels are 0 indexed #12354

Open
1 task
esizer opened this issue Dec 19, 2024 · 0 comments
Open
1 task

🐛 Card repeater action item labels are 0 indexed #12354

esizer opened this issue Dec 19, 2024 · 0 comments
Labels
accessibility Issues related to accessibility bug Something isn't working.

Comments

@esizer
Copy link
Member

esizer commented Dec 19, 2024

🐛 Bug

The action items for our card repeater (edit, remove) are 0 indexed so may cause issues for screen readers.

🦋 Expected Behaviour

References to items are 1 based indexed and not 0 based.

📋 Steps to Reproduce

  1. Login as applicant [email protected]
  2. Navigate to a skill showcase /applicant/skills/showcase/top-5-behavioural-skills
  3. Add a skill to show the delete button
  4. Open the accessibility tree inspector
  5. Inspect the delete button
  6. Observe the name being "Remove item 0" on the first item

📸 Screenshot

2024-12-19_10-40

🙋‍♀️ Proposed Solution

Increment the index for the action buttons by 1.

✅ Acceptance Criteria

  • Actions buttons are 1 based indexed
@esizer esizer added the bug Something isn't working. label Dec 19, 2024
@esizer esizer added the accessibility Issues related to accessibility label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility bug Something isn't working.
Projects
Status: No status
Development

No branches or pull requests

1 participant