-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve asm copy propagation for MOVE instruction #6641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6641 will not alter performanceComparing Summary
|
xunilrj
force-pushed
the
xunilrj/cpy-propagation-move
branch
from
November 15, 2024 11:04
63b0bfa
to
80d5a52
Compare
vaivaswatha
approved these changes
Nov 16, 2024
vaivaswatha
previously approved these changes
Nov 20, 2024
xunilrj
force-pushed
the
xunilrj/cpy-propagation-move
branch
from
November 22, 2024 18:32
ff484be
to
adb324f
Compare
Do you think we can have numbers before and after this change? maybe for just one or two important contracts if not our testsuite. |
vaivaswatha
approved these changes
Nov 25, 2024
IGI-111
approved these changes
Nov 25, 2024
kayagokalp
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improve value propagation optimization in two ways:
1 - First, when the optimizer knows that both source and destination registers of the
MOVE
instruct have the same value and version; it will remove the instruction as it is useless;2 - Otherwise, we propagate the value saying that destination now have the same value and version of the source register for other optimizations.
Checklist
Breaking*
orNew Feature
labels where relevant.