markdown-link-checker on CI fails for docs.rs links of unreleased versions
#1168
Labels
Comments
Br1ght0ne
added
documentation
6 tasks
Br1ght0ne
added a commit
that referenced
this issue
May 21, 2024
While #1168 is unfinished, we should hardcode the used versions in the documentation URLs. Please note that this PR: - does **NOT** address #1168 - requires incorporating the updating of versions in the changed files on each release. @digorithm ### Checklist - [x] I have linked to any relevant issues. - [x] I have updated the documentation. - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added necessary labels. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
This comment was marked as off-topic.
This comment was marked as off-topic.
ak-tech007
added a commit
to ak-tech007/Rust-SDK
that referenced
this issue
Dec 6, 2024
While FuelLabs/fuels-rs#1168 is unfinished, we should hardcode the used versions in the documentation URLs. Please note that this PR: - does **NOT** address #1168 - requires incorporating the updating of versions in the changed files on each release. @digorithm ### Checklist - [x] I have linked to any relevant issues. - [x] I have updated the documentation. - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added necessary labels. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our versioned links (
docs.rs/{{versions.package-name}}, implemented in #1098) work great, unless the PR bumps the versions to prepare for a release. In this case, the replaced links in the CI run for this release PR will point to a (yet) unreleased version of afuels-*package.The CI check should be made skippable/not required to allow seamless releases and versioned links at the same time.
The text was updated successfully, but these errors were encountered: