Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ignoring testnet_hello_world test #1144

Closed
Br1ght0ne opened this issue Sep 27, 2023 · 4 comments · Fixed by #1175
Closed

Revert ignoring testnet_hello_world test #1144

Br1ght0ne opened this issue Sep 27, 2023 · 4 comments · Fixed by #1175
Assignees
@Br1ght0ne
Labels
blocked bug Something isn't working ci GitHub CI build/pipeline

Comments

@Br1ght0ne
Copy link
Contributor

Once FuelLabs/fuel-core#1384 is in, #1143 should be reverted.
@Br1ght0ne Br1ght0ne added bug Something isn't working ci GitHub CI build/pipeline labels Sep 27, 2023
@Br1ght0ne Br1ght0ne self-assigned this Sep 27, 2023
@Br1ght0ne Br1ght0ne mentioned this issue Sep 27, 2023
Merged
6 tasks
@digorithm
Copy link
Member

This should be closed since #1143 went in, right?

@Br1ght0ne
Copy link
Contributor Author

@digorithm Once the fuel-core issue is in, we can revert our PR (e.g. re-enable the test), and then this issue will be closed. :)

@digorithm
Copy link
Member

Sorry, what fuel-core issue?

@Br1ght0ne
Copy link
Contributor Author

@digorithm FuelLabs/fuel-core#1384

@Br1ght0ne Br1ght0ne mentioned this issue Oct 30, 2023
Merged
Br1ght0ne added a commit that referenced this issue Oct 30, 2023
@Br1ght0ne @hal3e
Revert "fix(ci): ignore testnet_hello_world test" (#1175)
10fe3bb 
Reverts #1143. Closes #1144.

Co-authored-by: hal3e <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Br1ght0ne Br1ght0ne

Labels
blocked bug Something isn't working ci GitHub CI build/pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "fix(ci): ignore testnet_hello_world test" FuelLabs/fuels-rs
2 participants
@digorithm @Br1ght0ne