Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination queries for balances endpoint #2490

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Pagination queries for balances endpoint #2490

wants to merge 20 commits into from
+281 −56

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Dec 10, 2024 •
edited
Loading

Closes #2023

TODO:

  • Add integration test due to custom logic related to base asset id
  • Make it work properly with base asset id

Description

This PR enables the paginated queries for balances, but only if the balance indexation is enabled. Otherwise, the attempt to send paginated query will result with Can not use pagination when balances indexation is not available error.

Checklist

  • New behavior is reflected in tests

Before requesting review

  • I have reviewed the code myself

rafal-ch added 19 commits December 3, 2024 15:08
@rafal-ch
Unlock pagination for balances() query
d4a6596
@rafal-ch
Merge remote-tracking branch 'upstream/master' into rafal/2032_pagina…
4e0450b 
…tion_for_balances
@rafal-ch
Fix typos
aa7ee75
@rafal-ch
Remove TODO since indexer is no more
449775d
@rafal-ch
Support pagination queries for balances endpoint
b2fe429
@rafal-ch
Update PR number in the changelog
4131855
@rafal-ch
Fix formatting
2dd9aef
@rafal-ch
Add test for balances pagination
05f6851
@rafal-ch
Clean up pagination test
5b010e4
@rafal-ch
Add balances_reversed_pagination_without_base_asset() test
17a7ef4
@rafal-ch
Include message coins in balance pagination tests
73f50c0
@rafal-ch
Balances pagination supports base asset id
c172d1b
@rafal-ch
Full coverage of balances pagination in integration tests
fdd2c11
@rafal-ch
Simplify balance pagination tests
6dbc7a6
@rafal-ch
Dodge a double-test glitch in test_case
32d680f
@rafal-ch
Make balances test more clear
088c50b
@rafal-ch
Test paginated balances using various chunk sizes
695f99a
@rafal-ch
Simplify the implementation of balances query
f109d1b
@rafal-ch
Update changelog
27970eb
@rafal-ch rafal-ch marked this pull request as ready for review December 11, 2024 10:27
@rafal-ch rafal-ch requested a review from a team December 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pagination support for balances endpoint on GraphQL
1 participant
@rafal-ch