Allow Symfony 7 #3067
Allow Symfony 7 #3067
Conversation
simoheinonen
commented
Dec 13, 2023
simoheinonen
commented
- fixes Allow Symfony 7 #3066
simoheinonen
force-pushed
the
sf7
branch
2 times, most recently
from
69c5a82
to
955a1db
Compare
.github/workflows/ci.yaml
Outdated
| @@ -26,6 +26,12 @@ jobs: | |||
| - description: 'Symfony 5.*' | |||
| php: '8.1' | |||
| symfony-versions: '^5.4' | |||
| - description: 'Symfony 6.*' | |||
| php: '8.1' | |||
| symfony-versions: '^6.3' | |||
.github/workflows/ci.yaml
Outdated
| symfony-versions: '^6.3' | ||
| - description: 'Symfony 7.*' | ||
| php: '8.2' | ||
| symfony-versions: '^7.0' |
There was a problem hiding this comment.
This job should be removed as we don't have a LTS version of Symfony 7 yet anyway. Symfony 7 will already be tested in the normal job for PHP 8.2 as that will be the compatible version.
Model/User.php
Outdated
| * @return void | ||
| */ | ||
| public function eraseCredentials() | ||
| public function eraseCredentials(): void |
There was a problem hiding this comment.
this is a BC break for child classes. If this is required to support Symfony 7, it means we will have to release it as a new major version (in which case we might want to first do a new minor version to ensure that we have the appropriate @return everywhere so that our new major version can switch to native return types everywhere)
There was a problem hiding this comment.
I can see you added the return types in #3069 but never released it. Can you do that?
Should I go ahead and add the native return types in this PR and then we could get new major version out or should that be separate PR?
|
Hi guys! Thank you for your work! |
|
Hi, any news for Symfony 7 compatibility ? |
