Update GitHub actions, fix NPMv16 deprecation #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to use latest v4 for: - actions/checkout → solves NPMv16 deprecation - actions/cache Use latest Ubuntu, upgrade from ubuntu-20.04
|
If you can get the JS test running again I will merge this. |
|
Hi @tobias-93 I tried but my got stuck 😞 I would need some help here, not sure why that test if failing, looks like the tool is not available or installed 🤷 |
|
Looks like both PhantomJS and the Google Closure Library which are being used for the JS unit tests are legacy tools which are no longer supported. This means that the JS tests need to be rewritten to a new library, for which Google (the developers, not the search engine) suggests Jasmine, Chai, Mocha, Jest, etc. This has no high priority for me, but feel free to see if you can rework the tests if you are familiar with any of these frameworks or if you feel like learning one of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use latest v4.x for:
Use latest Ubuntu, upgrade from ubuntu-20.04