feat: define some property and return types

FriendsOfShopware · Sep 9, 2023 · 9679476 · 9679476
1 parent c4a5ce8
commit 9679476
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 16 deletions.
diff --git a/src/CrossSellingComparable/CrossSellingComparableEntity.php b/src/CrossSellingComparable/CrossSellingComparableEntity.php
@@ -10,20 +10,11 @@ class CrossSellingComparableEntity extends Entity
 {
     use EntityIdTrait;
 
-    /**
-     * @var string
-     */
-    protected $productCrossSellingId;
+    protected string $productCrossSellingId;
 
-    /**
-     * @var ProductCrossSellingEntity
-     */
-    protected $productCrossSelling;
+    protected ProductCrossSellingEntity $productCrossSelling;
 
-    /**
-     * @var bool|null
-     */
-    protected $isComparable;
+    protected ?bool $isComparable;
 
     public function getProductCrossSellingId(): string
     {

diff --git a/src/Migration/Migration1594488930CrossSellingComparable.php b/src/Migration/Migration1594488930CrossSellingComparable.php
@@ -14,7 +14,7 @@ public function getCreationTimestamp(): int
 
     public function update(Connection $connection): void
     {
-        $connection->executeUpdate('
+        $connection->executeStatement('
             CREATE TABLE `frosh_cross_selling_comparable` (
                 `id` BINARY(16) NOT NULL PRIMARY KEY,
                 `product_cross_selling_id` BINARY(16) NOT NULL,

diff --git a/src/Subscriber/FroshCrossSellingProductListingSubscriber.php b/src/Subscriber/FroshCrossSellingProductListingSubscriber.php
@@ -15,6 +15,7 @@
 use Shopware\Core\Content\Product\SalesChannel\Listing\ProductListingResult;
 use Shopware\Core\Content\Product\SalesChannel\SalesChannelProductEntity;
 use Shopware\Core\Framework\DataAbstractionLayer\Search\Filter\EqualsFilter;
+use Shopware\Core\Framework\DataAbstractionLayer\Search\Filter\MultiFilter;
 use Shopware\Core\Framework\DataAbstractionLayer\Search\Filter\NotFilter;
 use Shopware\Core\System\SalesChannel\SalesChannelContext;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
@@ -27,7 +28,7 @@ public function __construct(
     ) {
     }
 
-    public static function getSubscribedEvents()
+    public static function getSubscribedEvents(): array
     {
         return [
             ProductCrossSellingStreamCriteriaEvent::class => [
@@ -68,7 +69,7 @@ public function handleCriteriaLoadedRequest(ProductCrossSellingCriteriaEvent $ev
             ->addAssociation('properties.group')
             ->addAssociation('properties.media')
             ->addAssociation('mainCategories.category')
-            ->addFilter(new NotFilter(NotFilter::CONNECTION_AND, [new EqualsFilter('id', $crossSelling->getProductId())]))
+            ->addFilter(new NotFilter(MultiFilter::CONNECTION_AND, [new EqualsFilter('id', $crossSelling->getProductId())]))
             ->setLimit(CompareProductPageLoader::MAX_COMPARE_PRODUCT_ITEMS);
     }
 

diff --git a/src/Subscriber/FroshProductGatewayCriteriaSubscriber.php b/src/Subscriber/FroshProductGatewayCriteriaSubscriber.php
@@ -7,7 +7,7 @@
 
 class FroshProductGatewayCriteriaSubscriber implements EventSubscriberInterface
 {
-    public static function getSubscribedEvents()
+    public static function getSubscribedEvents(): array
     {
         return [
             ProductGatewayCriteriaEvent::class => [