Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't have pop-up when click "CLICK HERE TO REVIEW AND ACCEPT THE NEW TERMS" #53

Open
rydzacode opened this issue May 26, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@rydzacode
Copy link

Hello, I have one problem with this extension, when I click "CLICK HERE TO REVIEW AND ACCEPT THE NEW TERMS" I don't see "Terms Update" popup. The forum gets darker, but the window doesn't pop up.

Environment

Screenshot:

@rydzacode rydzacode added the bug Something isn't working label May 26, 2024
@ysmla
Copy link

ysmla commented May 26, 2024

是的,我也是
Flarum
1.8.5
php8.2
MySQL
8.2.0

@lwxining
Copy link

so am i。
Safari Firefox chromium
Uploading 截屏2024-05-31 14.38.36.png…

@bigreja
Copy link

bigreja commented Jun 1, 2024

Same here on safari, macos

javascript errors on console:
[Error] TypeError: undefined is not an object (evaluating 'r["@context"].toLowerCase')
(função anónima) (forum.superbraga.com:3:186)
Código global (forum.superbraga.com:3:363)

[Error] TypeError: undefined is not an object (evaluating 'r().session.user.fofTermsPoliciesState()[t.id()]')

(função anónima) — AcceptPoliciesModal.js:28
filter
(função anónima) — AcceptPoliciesModal.js:27
(função anónima) — AcceptPoliciesModal.js:22
(função anónima) — Modal.tsx:164
a — render.js:30
(função anónima) — render.js:155
(função anónima) — render.js:160
c — render.js:66
l — render.js:50
(função anónima) — render.js:134
c — render.js:63
l — render.js:50
f — render.js:277
(função anónima) — render.js:444
p — render.js:415
f — render.js:302
(função anónima) — render.js:444
p — render.js:415
(função anónima) — render.js:488
p — render.js:419
(função anónima) — render.js:488
p — render.js:419
f — render.js:302
(função anónima) — render.js:964
a — mount-redraw.js:14
(função anónima) — mount-redraw.js:25

a (forum.js:2:123358)
(função anónima) (forum.js:2:123409)

@Vladimir-Urik
Copy link

Vladimir-Urik commented Jun 1, 2024

Same issue.

TypeError: r().session.user.fofTermsPoliciesState() is undefined
    o AcceptPoliciesModal.js:28
    body AcceptPoliciesModal.js:27
    content AcceptPoliciesModal.js:22
    view Modal.tsx:164
    a render.js:30
    c render.js:155
    c render.js:160
    c render.js:66
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    f render.js:277
    p render.js:444
    p render.js:415
    f render.js:302
    p render.js:444
    p render.js:415
    p render.js:488
    p render.js:419
    p render.js:488
    p render.js:419
    f render.js:302
    exports render.js:964
    a mount-redraw.js:14
    u mount-redraw.js:25
    u mount-redraw.js:23
    handleEvent render.js:890
    L render.js:910
    k render.js:735
    c render.js:730
    c render.js:122
    c render.js:63
    c render.js:162
    c render.js:66
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    c render.js:162
    c render.js:66
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    c render.js:162
    c render.js:66
    l render.js:50
    c render.js:103
    c render.js:62
    p render.js:487
    p render.js:419
    f render.js:302
    exports render.js:964
    a mount-redraw.js:14
    m router.js:114
    promise callback*t router.js:126
    k router.js:95
    a render.js:30
    exports render.js:971
    mount mount-redraw.js:45
    y router.js:160
    mount Application.tsx:328
    mount ForumApplication.tsx:114
    boot Application.tsx:299
    <anonymous> (index):118
mount-redraw.js:15:23

@cgh1999520
Copy link

Same issue.

@clarkwinkelmann
Copy link
Member

This has been broken in #50 / 1.3.1. UserPoliciesStateModal was updated to load the policies when opened, but AcceptPoliciesModal has not received that code, breaking it.

@nxmndr
Copy link

nxmndr commented Jun 20, 2024

This would need some automated testing.

@fushengwushi
Copy link

Same issue.

@fushengwushi
Copy link

the issue can be fixed after back to old version
composer require fof/terms:"1.3.0"

@Lithrun
Copy link

Lithrun commented Sep 25, 2024

the issue can be fixed after back to old version composer require fof/terms:"1.3.0"

This fixed the issue for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants