From 85a197b107b5a69ac3e80d1b95b050f56ffa1dbe Mon Sep 17 00:00:00 2001 From: NovikovViktor Date: Mon, 1 Feb 2016 20:59:51 +0200 Subject: [PATCH] Avoid FCQN in doc-blocks --- Controller/DashboardController.php | 26 +++++++++++++------------- FOACronBundle.php | 3 +++ Manager/CronManager.php | 2 +- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/Controller/DashboardController.php b/Controller/DashboardController.php index 4772023..38836e6 100755 --- a/Controller/DashboardController.php +++ b/Controller/DashboardController.php @@ -10,6 +10,8 @@ use FOA\CronBundle\Manager\CronManager; use Symfony\Bundle\FrameworkBundle\Controller\Controller; use Oro\Bundle\SecurityBundle\Annotation\AclAncestor; +use Symfony\Component\HttpFoundation\Request; +use Symfony\Component\HttpFoundation\RedirectResponse; /** * Display dashboard and manage CRUD operations @@ -17,7 +19,7 @@ class DashboardController extends Controller { /** - * Displays the current crons and a form to add a new one. + * Displays the current crontab and a form to add a new one. * * @AclAncestor("foa_cron_management_index") * @@ -41,8 +43,8 @@ public function indexAction() /** * Add a cron to the cron table * - * @param \Symfony\Component\HttpFoundation\Request $request - * @return \Symfony\Component\HttpFoundation\RedirectResponse|Response + * @param Request $request + * @return RedirectResponse|Response */ public function addAction(Request $request) { @@ -72,7 +74,7 @@ public function addAction(Request $request) * Edit a cron * * @param $id - the line of the cron in the cron table - * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response + * @return RedirectResponse|Response */ public function editAction($id) { @@ -102,7 +104,7 @@ public function editAction($id) * Wake up a cron from the cron table * * @param $id - the line of the cron in the cron table - * @return \Symfony\Component\HttpFoundation\RedirectResponse + * @return RedirectResponse */ public function wakeupAction($id) { @@ -112,7 +114,7 @@ public function wakeupAction($id) $this->addFlash('error', $cronManager->getError()); /** - * @var \FOA\CronBundle\Manager\Cron $cron + * @var Cron $cron */ $cron = $cronList[$id]; $cron->setSuspended(false); @@ -128,7 +130,7 @@ public function wakeupAction($id) * Suspend a cron from the cron table * * @param $id - the line of the cron in the cron table - * @return \Symfony\Component\HttpFoundation\RedirectResponse + * @return RedirectResponse */ public function suspendAction($id) { @@ -138,7 +140,7 @@ public function suspendAction($id) $this->addFlash('error', $cronManager->getError()); /** - * @var \FOA\CronBundle\Manager\Cron $cron + * @var Cron $cron */ $cron = $cronList[$id]; $cron->setSuspended(true); @@ -154,7 +156,7 @@ public function suspendAction($id) * Remove a cron from the cron table * * @param $id - the line of the cron in the cron table - * @return \Symfony\Component\HttpFoundation\RedirectResponse + * @return RedirectResponse */ public function removeAction($id) { @@ -173,7 +175,7 @@ public function removeAction($id) * * @param $id - the line of the cron in the cron table * @param $type - the type of file, log or error - * @return \Symfony\Component\HttpFoundation\Response + * @return Response */ public function fileAction($id, $type) { @@ -181,7 +183,7 @@ public function fileAction($id, $type) $cronList = $cronManager->get(); /** - * @var \FOA\CronBundle\Manager\Cron $cron + * @var Cron $cron */ $cron = $cronList[$id]; @@ -207,9 +209,7 @@ protected function addFlash($type, $message) return; } - /* @var \Symfony\Component\HttpFoundation\Session\SessionInterface $session */ $session = $this->get('session'); - $session->getFlashBag()->add($type, $message); } } diff --git a/FOACronBundle.php b/FOACronBundle.php index 9e9bb20..a3afeb8 100755 --- a/FOACronBundle.php +++ b/FOACronBundle.php @@ -4,6 +4,9 @@ use Symfony\Component\HttpKernel\Bundle\Bundle; +/** + * Integration of Cron management board and Akeneo + */ class FOACronBundle extends Bundle { } diff --git a/Manager/CronManager.php b/Manager/CronManager.php index 36b3080..9f8eb5b 100755 --- a/Manager/CronManager.php +++ b/Manager/CronManager.php @@ -80,7 +80,7 @@ public function add(Cron $cron) /** * Remove a cron from the cron table * - * @param $index The line number + * @param $index - the line number */ public function remove($index) {