Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to libgit2 #1213

Closed
MailYouLater opened this issue Aug 2, 2019 · 2 comments
Closed

Switch to libgit2 #1213

MailYouLater opened this issue Aug 2, 2019 · 2 comments

Comments

@MailYouLater
Copy link

MailYouLater commented Aug 2, 2019

There have been issues with ungit which stem from the fact that ungit calls git on a command line, and interprets its output. Most notably, there were issues if git was set to use a language other than English. See #959 & #963.

I suggest that you switch to libgit2 to accomplish git tasks, instead of calling the git command for these functions, this would avoid any similar issues in the future.

@jung-kim
Copy link
Collaborator

jung-kim commented Aug 2, 2019

so with #1208 multi lang shouldn't be an issue.

There are other arguments for libgit2 and we've had discussions before #260 and it maybe worth to revisit again but yes it will be a big overhaul.

@MailYouLater MailYouLater changed the title Switch to libgit2 to avoid issues with non-English git Switch to libgit2 Aug 2, 2019
@wmertens
Copy link
Contributor

I think this issue is just a duplicate of #260 and can therefore be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants