Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Language/ Node::language property #1899

Closed
oxisto opened this issue Dec 14, 2024 · 0 comments · Fixed by #1913
Closed

Improvements to Language/ Node::language property #1899

oxisto opened this issue Dec 14, 2024 · 0 comments · Fixed by #1913
Labels
core discussion Label for issues or future features to be discussed before putting them onto the road-map

Comments

@oxisto
Copy link
Member

oxisto commented Dec 14, 2024

There are some issues that we have with language that we should tackle at some point

  • Node::language is a nullable field, which is kind of annoying and we had issues in the past where we didn't catch that it was null and things went horribly wrong. Instead I would propose an UnknownLanguage similar to the UnknownType (or ProblemLanguage?)
  • We currently do not set the language on component and translation result, which is understandable because it could potentially be multiple languages; but in an analysis the information that this for example is a pure python component (or which languages) are in there is definitely interesting. It might also be interesting for certain passes. I would therefore propose to a) set the language if all sub-nodes are of one language b) introduce something like a MultipleLanguages language which contains all languages used
@oxisto oxisto added discussion Label for issues or future features to be discussed before putting them onto the road-map core labels Dec 14, 2024
@oxisto oxisto changed the title Proposal: Improvements to Language/ Node::language property Improvements to Language/ Node::language property Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core discussion Label for issues or future features to be discussed before putting them onto the road-map
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant