Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector region coordinates and buy link hard to read on certain backgrounds #188

Open
Zanaras opened this issue Apr 25, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers Priority: Medium Medium priority issue

Comments

@Zanaras
Copy link

Zanaras commented Apr 25, 2024

While region coordinates can be inferred from neighboring regions, the off-white buy link and the white x,y coordinates are very hard to read on the beach and mountain region types. Beach is difficult because the colors blend very well into the sandy background image and the mountain because they don't seem to have an image and thus render as white.

Based on my research this is likely generated by the code at templates/game/macros/map.html.twig and templates/game/macros/map.html.twig.

A related issue happens when hovering on the buy link on ocean, but you can read it easily before hovering over it.

The span of line 28 on map.html.twig could be changed to have an if/else in twig that changes the color depending on region type, as below,or you could swap this for a more commonly visible color.

{% if tileData.type != 'beach' or tileData.type != 'mountain' %}<span style="color:white">{% else %}<span style="color:black">{% endif %}{{ tileData.x }}, {{ tileData.y }}</span><br />

This could be fixed for the links below that by either using a new class for the tags, adding it to the CSS, or changing the existing CSS to have a more visible color.

@frank9999 frank9999 added enhancement New feature or request good first issue Good for newcomers Priority: Medium Medium priority issue labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Priority: Medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants