Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default for queue driver #2

Open
FoxxMD opened this issue Nov 11, 2016 · 3 comments
Open

Better default for queue driver #2

FoxxMD opened this issue Nov 11, 2016 · 3 comments

Comments

@FoxxMD
Copy link
Owner

FoxxMD commented Nov 11, 2016

Should we attempt to find the default queue driver specified in Laravel's /config/queue.php? Or throw an exception and force the user to explicitly set it?

@soham2008xyz
Copy link

Hi, just stumbled upon your package, it really gave me a good starting point for my own solution.

I updated some configuration to be compatible with Laravel 5.7 (env('QUEUE_CONNECTION') instead of env('QUEUE_DRIVER')) and used config('queue.default') to parse the default queue driver. Be happy to send you pull request for the changes, if you are interested.

Let me know your thoughts on this approach, and once again, thanks for this package! 👍

@FoxxMD
Copy link
Owner Author

FoxxMD commented Feb 20, 2019

Glad it helped! I'm happy to accept PRs as long as it doesn't break current functionality.

@basnetjiten
Copy link

please update the QUE_DRIVER with QUEUE_CONNECTION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants