Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metrics abstraction to be more performant #208

Open
ejsmith opened this issue Apr 26, 2020 · 0 comments
Open

Change metrics abstraction to be more performant #208

ejsmith opened this issue Apr 26, 2020 · 0 comments

Comments

@ejsmith
Copy link
Contributor

ejsmith commented Apr 26, 2020

Our current metrics abstraction forces users to pass the name of the metric with every single call to update the metric (increment, decrement, etc). We should be able to define the configuration for our metrics as a static or singleton somewhere and then just call methods on it like Increment() without having to have any string allocations.

Also, we need to support adding labels / dimensions to metrics for things like hostname, etc. Possibly support metric scopes for defining labels that should be added to all metrics within it (#114 #32).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants