Helper#icon prepends fa- to given fa class string #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex: icon('flag 2x') rather than icon('flag', class: 'fa-2x')
| @@ -5,7 +5,8 @@ module ViewHelpers | |||
| def icon(icon, text = nil, html_options = {}) | |||
| text, html_options = nil, text if text.is_a?(Hash) | |||
|
|
|||
| content_class = "fa fa-#{icon}" | |||
| icons = icon.split(" ").map { |icon| "fa-#{icon}" }.join(" ") | |||
There was a problem hiding this comment.
Shadowing outer local variable - icon.
nnattawat
force-pushed
the
handle-icon-array
branch
from
f5ea06f to
09d0c7d
Compare
| @@ -4,8 +4,8 @@ module Rails | |||
| module ViewHelpers | |||
| def icon(icon, text = nil, html_options = {}) | |||
| text, html_options = nil, text if text.is_a?(Hash) | |||
|
|
|||
| content_class = "fa fa-#{icon}" | |||
| icon = icon.split(' ').map { |icon| "fa-#{icon}" }.join(' ') | |||
There was a problem hiding this comment.
Shadowing outer local variable - icon.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
nnattawat
force-pushed
the
handle-icon-array
branch
2 times, most recently
from
c15208c to
18dec73
Compare
| @@ -5,7 +5,7 @@ module ViewHelpers | |||
| def icon(icon, text = nil, html_options = {}) | |||
| text, html_options = nil, text if text.is_a?(Hash) | |||
|
|
|||
| content_class = "fa fa-#{icon}" | |||
| content_class = "fa #{icon.split(' ').map { |i| "fa-#{i}" }.join(' ')}" | |||
There was a problem hiding this comment.
I think it's not that long haha :)
|
You should probably call |
|
How about optional array instead? |
nnattawat
force-pushed
the
handle-icon-array
branch
from
18dec73 to
6acfa88
Compare
| @@ -5,7 +5,8 @@ module ViewHelpers | |||
| def icon(icon, text = nil, html_options = {}) | |||
| text, html_options = nil, text if text.is_a?(Hash) | |||
|
|
|||
| content_class = "fa fa-#{icon}" | |||
| icons = icon.is_a?(Array) ? icon : icon.to_s.split(' ') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
@nickpearson and @andreykul good points guys. I have made it to support more formats. icon(:flag)
# => <i class="fa fa-flag">icon('flag')
# => <i class="fa fa-flag">icon([:flag, :fw, '2x'])
# => <i class="fa fa-flag fa-fw fa-2x">icon("flag fw 2x")
# => <i class="fa fa-flag fa-fw fa-2x"> |
…flag fa-2x'> now we can do:
- icon('flag 2x')
- icon([:flag, '2x'])
nnattawat
force-pushed
the
handle-icon-array
branch
from
6acfa88 to
825bbac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the improvement on the helper method. Now it can handle multiple
fa-classes.For example, to add
fa-2xclass we need to useicon('flag', class='fa-2x')which make more sense to use it as the following.