Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_scheme() 'mono', actually renders 4 colors instead of 5 #43

Open
branylagaffe opened this issue Oct 22, 2014 · 4 comments
Open

make_scheme() 'mono', actually renders 4 colors instead of 5 #43

branylagaffe opened this issue Oct 22, 2014 · 4 comments

Comments

@branylagaffe
Copy link

I've no idea if the output is intended and the documentation is wrong, or vice versa.

@scratthunder
Copy link

+1
Just found the same problem.

@Shuunen
Copy link

Shuunen commented Oct 22, 2015

how do you use make_scheme() ? please give an example

@GeorgeKagan
Copy link

Got same problem, code used is:

var hsv    = Please.HEX_to_HSV('#d9534f');
var colors = Please.make_scheme({
    h: hsv.h,
    s: hsv.s,
    v: hsv.v
}, {
    scheme_type: 'monochromatic',
    format: 'hex'
});

@branylagaffe
Copy link
Author

branylagaffe commented Oct 24, 2017

I think you just forgot to push the "base" colors at line 483

adjusted = clone( HSV );
scheme.push( adjusted );

Something like that should do it,

if you're still willing to maintain this repo >.>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants