Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations no longer work with upgrade from 2.1.0 -> 2.1.1 #12

Open
Tandashi opened this issue Nov 17, 2023 · 3 comments
Open

Translations no longer work with upgrade from 2.1.0 -> 2.1.1 #12

Tandashi opened this issue Nov 17, 2023 · 3 comments

Comments

@Tandashi
Copy link

With the update from version 2.1.0 to 2.1.1 the translations stopped working and only display the first segment of the translation key which broke our production code. Our quick fix currently is explicitly use 2.1.0.

Files for a minimal example:
minimal-example.zip

My assumption:
With the change in implementation of LocalizationService.instance.read the translation broke IF the translation key contains dots due to the split that occurs now. However I don't see anywhere in the README.md that explicitly mentions that you shouldn't use dots to split your translation keys into segments for better structuring.

Is it intended that one shouldn't use dots to split the translation key? And if so it should probably be stated in the README.md what the best practices and pitfalls are.

@charcoast
Copy link

I also had this problem.

@digibum
Copy link

digibum commented Jan 18, 2024

Same issue here.

@leonardogbr
Copy link

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants