Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add support for strings #417

Conversation

brads-perc
Copy link

What does this change?

Added support for generating a dart class containing strings from both .yaml and .xml

Fixes #340 🎯

[FR]: Custom Constants Generate from XML. #340

Type of change

Please delete options that are not relevant.

  • [ x] New feature (non-breaking change which adds functionality)
  • [ x] This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run unit:test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@brads-perc brads-perc requested a review from wasabeef as a code owner August 25, 2023 13:50
@AlexV525
Copy link
Member

@brads-perc Hi. Are you still on this? Could you update your branch and remove unnecessary changes to make the request clean so we can do further review?

@AlexV525 AlexV525 marked this pull request as draft November 17, 2023 09:36
@pedalPusher68
Copy link

@AlexV525 - I will make the updates, etc.

@AlexV525
Copy link
Member

AlexV525 commented Mar 7, 2024

Please submit a new request before we can review it.

@AlexV525 AlexV525 closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Custom Constants Generate from XML.
3 participants