Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown #14

Closed
hlubek opened this issue Aug 4, 2021 · 0 comments · Fixed by #33
Closed

Graceful shutdown #14

hlubek opened this issue Aug 4, 2021 · 0 comments · Fixed by #33
Milestone
First supported v...

Comments

@hlubek
Copy link
Member

hlubek commented Aug 4, 2021

Scenario: Running jobs in prunner and the process is shut down or restarted
Implementation: Handle interrupt signal and cancel running jobs and wait until complete (would make sense with #11) until some wait time (configurable in pipeline definition) before doing a hard stop of running tasks.
@hlubek hlubek added this to the First supported version milestone Aug 4, 2021
hlubek added a commit that referenced this issue Apr 4, 2022
@hlubek
FEATURE: Graceful shutdown and process groups for child processes
c593dff 
Implements shutdown via SIGINT (graceful) and SIGTERM (cancelling jobs).
Also fix an issue with child processes from scripts by setting setpgid
to start processes (which is needed to prevent signals being forwarded).

Closes #14
@hlubek hlubek mentioned this issue Apr 4, 2022
Merged
@hlubek hlubek closed this as completed in #33 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First supported version
Development

Successfully merging a pull request may close this issue.

FEATURE: Graceful shutdown and process groups for child processes Flowpack/prunner
1 participant
@hlubek