Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers: animationEnabled and optimized properties questions #43

Open
paodb opened this issue Aug 20, 2021 · 4 comments
Open

Markers: animationEnabled and optimized properties questions #43

paodb opened this issue Aug 20, 2021 · 4 comments
Assignees

Comments

@paodb
Copy link
Member

paodb commented Aug 20, 2021

This two properties have no effect on markers when set to true.

  • animationEnabled: property on google-map web-component is called animation and it expects a String that represents the type or animation. It has this comment: "A animation for the marker. "DROP" or "BOUNCE". See https://developers.google.com/maps/documentation/javascript/examples/marker-animations." In that example you can see that it needs to recibe an animation type. So my question is, what was the idea behind animationEnabled property on GoogleMapMarker class?
  • optimized: I didn't find any property with that name on the web-component. The JavaDoc says "Enables/disables marker optimization. If enabled, many markers are rendered as a single static element. Disable if you want to use animated GIFs or PNGs." but is doing when enabled. So, is this property supposed to exist on google-map? What it should do?
@paodb paodb added the question Further information is requested label Aug 20, 2021
@mlopezFC
Copy link
Member

Let's replace the first one for the animation property of the web component and try to see if it's working.
Regarding the second one, let's just remove that.

@mlopezFC mlopezFC assigned paodb and unassigned mlopezFC Mar 21, 2022
@paodb
Copy link
Member Author

paodb commented Apr 5, 2022

The animation property doesn't seem to be working on the web-component so I need to investigate a little bit more before doing more changes.

@paodb
Copy link
Member Author

paodb commented Jan 9, 2023

As this encloses two diferent actions, I've created a new issue for the removal of the optimized option #81.

@paodb paodb removed the question Further information is requested label Jan 9, 2023
@paodb
Copy link
Member Author

paodb commented Aug 10, 2023

The animation part it's tricky, I followed several examples like https://developers.google.com/maps/documentation/javascript/examples/marker-animations#maps_marker_animations-html but the web-component it's not triggering the animation. And even if that works, the current property in the java side, "animationEnabled" is a boolean and the web-component property is "animation" and it expects a String representing one of the two possible animation values: DROP or BOUNCE. So I think this "animationEnabled" property should be deprecated if not removed.

@paodb paodb moved this to Under consideration in Flowing Code Addons May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under consideration
Development

No branches or pull requests

2 participants