Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab selection from overflow only works if tab name is clicked #17

Open
paodb opened this issue Jul 5, 2024 · 2 comments · Fixed by #18
Open

Tab selection from overflow only works if tab name is clicked #17

paodb opened this issue Jul 5, 2024 · 2 comments · Fixed by #18
Assignees
@javier-godoy
Labels
bug Something isn't working

Comments

@paodb
Copy link
Member

paodb commented Jul 5, 2024

Describe the bug

When selecting a tab from the overflow menu, the content of the tab is only displayed if the name was click. If you click the remaining space in the item, it won't display the selected tab. This can be tested on https://addonsv24.flowingcode.com/googlemaps. See video:
tabs-google-maps-firefox

Expected behavior

When a tab is selected from the overflow menu, I expect the tab content to be displayed.

Minimal reproducible example

See attached video.

Add-on Version

1.1.0

Vaadin Version

24.4.1

Additional information

N/C
@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons Jul 5, 2024
@javier-godoy javier-godoy moved this from Inbox (needs triage) to To Do in Flowing Code Addons Jul 5, 2024
@javier-godoy javier-godoy self-assigned this Jul 5, 2024
@javier-godoy
Copy link
Member

Confirmed. The overflowed Tab does not cover the full with of the vaadin-menu-bar-item
image

Seems fixable with CSS
image

@javier-godoy javier-godoy added the bug Something isn't working label Jul 5, 2024
javier-godoy added a commit that referenced this issue Jul 5, 2024
@javier-godoy
fix: allow tab selection from overflow on entire tab area
33bea35 
Close #17
@javier-godoy javier-godoy mentioned this issue Jul 5, 2024
Merged
@javier-godoy javier-godoy moved this from To Do to In Progress in Flowing Code Addons Jul 8, 2024
@paodb paodb closed this as completed in #18 Jul 8, 2024
@paodb paodb closed this as completed in 3edaf50 Jul 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Flowing Code Addons Jul 8, 2024
@paodb
Copy link
Member Author

paodb commented Jul 8, 2024

Reopening issue per comment #18 (comment)

@paodb paodb reopened this Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Done to Inbox (needs triage) in Flowing Code Addons Jul 8, 2024
@paodb paodb moved this from Inbox (needs triage) to To Do in Flowing Code Addons Jul 8, 2024
@javier-godoy javier-godoy mentioned this issue Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javier-godoy javier-godoy

Labels
bug Something isn't working
Projects
Flowing Code Addons
Status: To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow tab selection from overflow on entire tab area FlowingCode/EnhancedTabs
2 participants
@javier-godoy @paodb