Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide Duration configuration does not work #38

Closed
robinovsky opened this issue Mar 7, 2024 · 4 comments
Closed

Slide Duration configuration does not work #38

robinovsky opened this issue Mar 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@robinovsky
Copy link

The property slideDuration seems to not be set properly. Whatever value is set, it always default to 5 seconds (default in the @xpertsea/paper-slider javascript)

Probable cause:
At Line 98 in Carousel.java, this.getElement().setProperty is used

 public void setSlideDuration(int slideDuration) {
    this.getElement().setProperty(SLIDE_DURATION, slideDuration);
  }

Shouldn't this.getElement().setAttribute be used instead as with the other parameters ?

@javier-godoy
Copy link
Member

Yes, I think it makes sense. Thanks for calling this into our attention.

@javier-godoy javier-godoy added the bug Something isn't working label Mar 8, 2024
@javier-godoy javier-godoy self-assigned this Mar 8, 2024
javier-godoy added a commit that referenced this issue Mar 8, 2024
@javier-godoy
Copy link
Member

The attribute slide-duration is mapped to the property slideDuration. We were using the wrong name with setProperty.

https://github.com/Link2Twenty/l2t-paper-slider/blob/5f75992afba75bce725e7d6772e3b3ec25ad00ee/l2t-paper-slider.html#L272-L285

@paodb paodb closed this as completed in 2c45893 Mar 8, 2024
@javier-godoy
Copy link
Member

Hello. The change has been merged into 2.1.3-SNAPSHOT, which is available from https://maven.flowingcode.com/snapshots/

@robinovsky
Copy link
Author

Thank you awesome response time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants