Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties update refactor needed #31

Closed
paodb opened this issue May 29, 2023 · 0 comments
Closed

Properties update refactor needed #31

paodb opened this issue May 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@paodb
Copy link
Member

paodb commented May 29, 2023

It has come to my attention that there's no need to have these properties defined in the Carousel class:

 private boolean autoProgress;
 private int slideDuration = DEFAULT_SLIDE_DURATION;
 private int startPosition;
 private boolean disableSwipe;
 private boolean hideNavigation;

See

These properties are then used in setter methods and do nothing to update the component. Component will be updated only when calling updateProperties method. The setter methods they should just update the attributes directly in the element as this.getElement().setAttribute(...);

This comes from issue #29.

@javier-godoy javier-godoy added the bug Something isn't working label May 29, 2023
mlopezFC added a commit that referenced this issue Jul 6, 2023
@paodb paodb closed this as completed in 5f9cfab Jul 6, 2023
@paodb paodb moved this to Done in Flowing Code Addons May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants