Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build failure for Vaadin 23 and 24 #27

Closed
javier-godoy opened this issue Mar 14, 2023 · 1 comment
Closed

CI build failure for Vaadin 23 and 24 #27

javier-godoy opened this issue Mar 14, 2023 · 1 comment
Assignees

Comments

@javier-godoy
Copy link
Member

After adding CI build checks for Vaadin 23 and 24 (588662e, 8678051, 676ed67) I found that 23 and 24 builds fail because of the removal of HtmlImport, which is used here

@HtmlImport("bower_components/l2t-paper-slider/l2t-paper-slider.html")

The add-on, however, IS compatible with Vaadin 23 and 24 because missing annotations do not throw any exception (see https://stackoverflow.com/q/3567413/1297272). We have demos at https://addonsv23.flowingcode.com/carousel and https://addonsv24.flowingcode.com/carousel

I think we should revert the mentioned commits, and keep CI for Vaadin 14 only.

@mlopezFC
Copy link
Member

mlopezFC commented Jul 6, 2023

I agree. Let's do that. If we have issues later we can just remove the annotation and stop supporting Vaadin versions < 14

@javier-godoy javier-godoy self-assigned this Jul 6, 2023
@paodb paodb closed this as completed in c57c263 Jul 7, 2023
@paodb paodb moved this to Done in Flowing Code Addons May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants