Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel within vaadin-dialog has strange auto-progress behaviour #21

Closed
GrandyB opened this issue Sep 15, 2021 · 6 comments · Fixed by #40
Closed

Carousel within vaadin-dialog has strange auto-progress behaviour #21

GrandyB opened this issue Sep 15, 2021 · 6 comments · Fixed by #40
Assignees
Labels
bug Something isn't working

Comments

@GrandyB
Copy link

GrandyB commented Sep 15, 2021

In our application we are wanting to show a Carousel within a Dialog.

With auto-progress enabled on the Carousel, the example code with 1/2/3/4 slides ping-pongs from 1 -> 3 -> 1 -> 3 etc. Never goes to slides 2 or 4.

Setting startPosition to be the 2nd slide, it instead goes 2 -> 4 -> 2 -> 4 etc.

Example Dialog code to replicate would be... (borrowing s1 to s4 from the existing examples):
add(new Button("Open", (e) -> new Dialog(new Carousel(s1,s2,s3,s4).withAutoProgress()).open()));

@javier-godoy javier-godoy self-assigned this Sep 15, 2021
@javier-godoy
Copy link
Member

Confirmed with Vaadin 14.6.8 / Carousel 2.1.2-SNAPSHOT

@javier-godoy javier-godoy added the bug Something isn't working label Sep 15, 2021
@javier-godoy javier-godoy removed their assignment Mar 17, 2022
@paodb paodb self-assigned this Mar 17, 2022
@paodb
Copy link
Member

paodb commented Apr 7, 2022

I was able to reproduce the issue but still haven't been able to figure out what's causing that behavior.

@mlopezFC
Copy link
Member

mlopezFC commented Jul 6, 2023

The problem is that the function attached is being called twice when inside the dialog.
I do not know right now how to avoid that. I'll keep investigating.

@Rlaxfax
Copy link

Rlaxfax commented Apr 3, 2024

Hello,
is there any update to this bug?I am facing the same issue.

Thanks in advance.

@CrisVnait
Copy link

I also have the problem described above and hope that an update will come in the next time.

@paodb
Copy link
Member

paodb commented Apr 22, 2024

Fix released in Carousel version 2.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

6 participants