Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start position 1 & one slide show 2 dots #19

Closed
paodb opened this issue Jul 21, 2021 · 4 comments
Closed

Start position 1 & one slide show 2 dots #19

paodb opened this issue Jul 21, 2021 · 4 comments
Assignees

Comments

@paodb
Copy link
Member

paodb commented Jul 21, 2021

This comes from #10 comment.

If the Carousel#withStartPosition-method is used (only tested it with a parameter = 1) with a carousel which holds only a single slide, there will be two dots displayed in the navigation instead of one dot.

@paodb paodb self-assigned this Jul 21, 2021
@paodb
Copy link
Member Author

paodb commented Jul 22, 2021

I wasn't able to reproduce this behavior. I did a simple test based on our current master:

    Slide s1 = new Slide(createSlideContent("Slide 1", "green"));
    Carousel c = new Carousel(s1);
    c.setWidth("100%");
    c.setHeight("180px");
    c.setStartPosition(1);
    add(c);

and it shows the only slide that was added and only one dot, like shown in the picture:

image

In fact, it doesn't matter if you chose a greater number to set in setStartPosition, it just displays one dot as there's only one slide.

@CoderGarm
Copy link

CoderGarm commented Jul 23, 2021

Hey,

I produced this issue in another setting:

member variable:
    Carousel c = new Carousel().withSlideDuration(4).withStartPosition(1);

constructor() {
    add(c);
}

addSlide(Sting title) {
    Slide s1 = new Slide(createSlideContent(title));
    c.setSlides(new Slide[]{s1};
}

The second dot occures at start and nothing is displayed:
slide1

If you use the slide-navigation the second dot disappears and the slide's content is displayed:
slide2

@paodb
Copy link
Member Author

paodb commented Mar 17, 2022

Hi @CoderGarm, sorry for the delay on this. Is this still an issue for you? In your latest example, no slides are being added to the carousel. I tried again as in #19 (comment) but not able to reproduce the double dot display. ( Tested in Carousel version 2.1.1 & Vaadin version 14.8.5).

@CoderGarm
Copy link

Hey,

it's not an issue. I've switched my application from the vaadin frontend to angular completely a few month ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants