Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromClient not used in SlideChangeEvent constructor #17

Closed
paodb opened this issue Jul 21, 2021 · 0 comments · Fixed by #18
Closed

fromClient not used in SlideChangeEvent constructor #17

paodb opened this issue Jul 21, 2021 · 0 comments · Fixed by #18
Assignees
@paodb

Comments

@paodb
Copy link
Member

paodb commented Jul 21, 2021 •
edited
Loading

SlideChangeEvent constructor should use "fromClient" instead of "true" in super call.

 public SlideChangeEvent(
        Carousel source, boolean fromClient, @EventData("event.detail.value") String position) {
      super(source, true);
    }
@paodb paodb self-assigned this Jul 21, 2021
paodb added a commit that referenced this issue Jul 21, 2021
@paodb
fix: fix super call in SlideChangeEvent constructor
589d8e5 
Close #17
@paodb paodb mentioned this issue Jul 21, 2021
Merged
paodb added a commit that referenced this issue Jul 21, 2021
@paodb
fix: fix fromClient not used in SlideChangeEvent constructor
f333d51 
Close #17
@javier-godoy javier-godoy changed the title SlideChangeEvent constructor super call issue fromClient not used in SlideChangeEvent constructor Jul 21, 2021
javier-godoy pushed a commit that referenced this issue Jul 21, 2021
@paodb @javier-godoy
fix: fix fromClient not used in SlideChangeEvent constructor
6c368f5 
Close #17
@paodb paodb moved this to Done in Flowing Code Addons May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paodb paodb

Labels
None yet
Projects
Flowing Code Addons
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix fromClient not used in SlideChangeEvent constructor FlowingCode/CarouselAddon
1 participant
@paodb