Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuation of derivedField fix - initial move to using non-polymorphic types #90

Open
wants to merge 1 commit into
base: jasoons/derived-fields
Choose a base branch
from
Open

Continuation of derivedField fix - initial move to using non-polymorphic types #90

wants to merge 1 commit into from

Conversation

JasoonS
Copy link
Member

@JasoonS JasoonS commented Dec 26, 2022

No description provided.

@JasoonS
Copy link
Member Author

JasoonS commented Dec 26, 2022

Related: #7

MJYoung114
MJYoung114 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@MJYoung114 MJYoung114 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me and is nice and clean, just need to fix the test first to check everything is still working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJYoung114 MJYoung114 MJYoung114 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasoonS @MJYoung114