-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Siri shortcut translation files are not handled #151
Comments
I haven't used Siri Shortcuts yet, so I'm not aware of this file. Can you please further explain how this is localized? Are there any Strings files? Can you list the different file paths? Are they below something like It is totally possible that we didn't cover those files yet. While I'm not sure how BartyCrouch could improve translation there, I'm definitely open for a PR that adds support for Siri Shortcuts. |
The files are located in the Base.lproj, en.proj locations. The .intent file is a xml file. |
+1 |
@patrickferreira I understand that. But my question, how BartyCrouch could help here is still not answered. I'm assuming you expect something similar to what BartyCrouch does with Interface Builder files, right? (Automatically updating the |
For your information |
I'm experiencing the same issue. And it still hasn't been fixed in version 4.x. Would be great if someone could take a look at this. |
@NMAC427 Thank you for bringing this up again. As I have noted above, BartyCrouch is currently based on tools from Apple (namely |
A few years ago I developed such a system myself for my own projects. It definitely is possible but the main problem with it is that Apple constantly creates breaking changes (i.e. new platform or new ui element). As long as Apple provides tools to generate .string files from storyboards, I would use their tools. That way you automatically get support for new ui elements and platforms. (This is also akin to the Unix philosophy where you build programs on top of other programs instead of reimplementing everything yourself.) Instead I would only create a custom implementation for handling files (like |
@NMAC427 Good points and don't worry, I won't be reimplementing anything that changes often and Apple (or the community) already provides an updated tool for. But But I will think about the design choices when I have the time to actually start working on this. |
Hello, is this still ongoing? |
I have an app which supports Siri Shortcuts, therefore I have a
.intentdefinition
file. This file is also translated, but it looks like, BartyCrouch ignores this file.The text was updated successfully, but these errors were encountered: