Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(csbs): fix docs issues. #995

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Sep 8, 2023

fix docs issues.

1、resource_flexibleengine_csbs_backup_policy_v1

provider_id is optional, in the following image do not have provider_id field but it is still created successfully
image

@Zippo-Wang Zippo-Wang force-pushed the fix_docs_CSBS branch 2 times, most recently from 2f98fdc to 8a7283c Compare September 8, 2023 08:59
docs/resources/csbs_backup_v1.md Outdated Show resolved Hide resolved
@Zippo-Wang Zippo-Wang force-pushed the fix_docs_CSBS branch 2 times, most recently from 56d3040 to d8cb603 Compare September 13, 2023 03:23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing field

"provider_id": {
				Type:     schema.TypeString,
				Optional: true,
				Default:  "fc4d5750-22e7-4798-8a46-f48f62c4c1da",
				ForceNew: true,
			},
``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no miss

@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Sep 15, 2023
@@ -20,53 +20,63 @@ data "flexibleengine_csbs_backup_policy_v1" "csbs_policy" {

The following arguments are supported:

* `id` - (Optional) Specifies the ID of backup policy.
* `region` - (Optional, String) The region in which to query the data source. If omitted, the provider-level region
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `region` - (Optional, String) The region in which to query the data source. If omitted, the provider-level region
* `region` - (Optional, String) The region in which to query the data source. If omitted, the provider-level region

@@ -20,25 +20,28 @@ data "flexibleengine_csbs_backup_v1" "csbs" {

The following arguments are supported:

* `id` - (Optional) Specifies the ID of backup.
* `region` - (Optional, String) The region in which to query the data source. If omitted, the provider-level region
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@github-actions github-actions bot removed the LGTM label Sep 18, 2023
@ShiChangkuo ShiChangkuo merged commit 1cf68a5 into FlexibleEngineCloud:master Sep 18, 2023
3 checks passed
@Zippo-Wang Zippo-Wang deleted the fix_docs_CSBS branch November 1, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants