Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cbr): add some fields for CBR #1085

Merged
merged 1 commit into from
Jan 3, 2024
Merged

docs(cbr): add some fields for CBR #1085

merged 1 commit into from
Jan 3, 2024

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Dec 27, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccCBRV3Policy_basic
=== PAUSE TestAccCBRV3Policy_basic
=== CONT  TestAccCBRV3Policy_basic
--- PASS: TestAccCBRV3Policy_basic (40.89s)
PASS

coverage: 1.6% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccCBRV3Policy_retention
=== PAUSE TestAccCBRV3Policy_retention
=== CONT  TestAccCBRV3Policy_retention
--- PASS: TestAccCBRV3Policy_retention (39.38s)
PASS
coverage: 1.6% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccCBRV3Policy_replication
=== PAUSE TestAccCBRV3Policy_replication
=== CONT  TestAccCBRV3Policy_replication
    acceptance.go:109: Skipping the replication policy acceptance tests.
--- SKIP: TestAccCBRV3Policy_replication (0.00s)

Test ignored.
PASS

coverage: 1.1% of statements in ../../../terraform-provider-flexibleengine/...

@github-actions github-actions bot added size/XS and removed size/S labels Dec 27, 2023
@chengxiangdong
Copy link
Contributor

/retitle docs(cbr): add some fields for CBR

@github-actions github-actions bot changed the title solve insufficient fields for cbr docs(cbr): add some fields for CBR Dec 28, 2023
chengxiangdong
chengxiangdong reviewed Dec 28, 2023
View reviewed changes
Copy link
Contributor

@chengxiangdong chengxiangdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs to fix some nits.

flexibleengine/acceptance/resource_flexibleengine_cbr_policy_test.go Outdated
@@ -241,6 +247,7 @@ resource "flexibleengine_cbr_policy" "test" {
daily = 10
weekly = 10
monthly = 1
full_backup_interval = -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
full_backup_interval = -1
full_backup_interval = -1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

flexibleengine/acceptance/resource_flexibleengine_cbr_policy_test.go Outdated
@@ -264,6 +271,7 @@ resource "flexibleengine_cbr_policy" "test" {
weekly = 20
monthly = 6
yearly = 1
full_backup_interval = 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ShiChangkuo ShiChangkuo merged commit 7528fec into FlexibleEngineCloud:master Jan 3, 2024
6 checks passed
Zippo-Wang pushed a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Jan 3, 2024
@Zhukun-Huawei @Zippo-Wang
docs(cbr): add some fields for CBR (FlexibleEngineCloud#1085)
e0c8281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiangdong chengxiangdong chengxiangdong left review comments

Assignees
No one assigned
Labels
documentation LGTM size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zhukun-Huawei @chengxiangdong @ShiChangkuo