Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(as/cbr/cse): processing Fields Referencing Huawei Cloud #1007

Merged

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Sep 12, 2023

1、resrouce_flexibleengine_cbr_vault

1.1 script test

image
image
image

2、resrouce_flexibleengine_cse_microservice_engine

2.1 script test

image
image
image

2.2 unit test already has the enterprise_project_id field.

3、data_source_flexibleengine_as_groups

3.1 unit test

=== RUN TestAccDataSourceASGroup_basic
=== PAUSE TestAccDataSourceASGroup_basic
=== CONT TestAccDataSourceASGroup_basic
--- PASS: TestAccDataSourceASGroup_basic (191.11s)
PASS

coverage: 3.7% of statements in ../../../terraform-provider-flexibleengine/...

3.2 script test

image
image
image

@Zippo-Wang Zippo-Wang force-pushed the fix_docs_reference_hwcloud branch 2 times, most recently from 3ead4a6 to 135194e Compare September 12, 2023 09:09
@Zippo-Wang Zippo-Wang changed the title docs(cbr/cse): processing Fields Referencing Huawei Cloud docs(as/cbr/cse): processing Fields Referencing Huawei Cloud Sep 12, 2023
return fmt.Sprintf(`
%s
data "flexibleengine_as_groups" "groups" {
enterprise_project_id = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format error

data "flexibleengine_as_groups" "groups" {
enterprise_project_id = ep_id
Copy link
Contributor

@chengxiangdong chengxiangdong Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enterprise_project_id = ep_id
enterprise_project_id = var.ep_id

@Zippo-Wang Zippo-Wang force-pushed the fix_docs_reference_hwcloud branch from 135194e to db4814e Compare September 13, 2023 02:42
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Sep 15, 2023
data "flexibleengine_as_groups" "groups" {
enterprise_project_id = var.ep_id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete this query parameter beacuse it should add whitelist for most users.

@@ -30,6 +33,9 @@ The following arguments are supported:
- **DELETING**: indicates that the AS group is being deleted.
- **FREEZED**: indicates that the AS group has been frozen.

* `enterprise_project_id` - (Optional, String, ForceNew) Specifies the enterprise project id of the AS group.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data source should be without ForceNew

@Zippo-Wang Zippo-Wang force-pushed the fix_docs_reference_hwcloud branch from db4814e to 847d043 Compare September 18, 2023 11:17
@github-actions github-actions bot removed the LGTM label Sep 18, 2023
@Zippo-Wang Zippo-Wang force-pushed the fix_docs_reference_hwcloud branch from 847d043 to 38c789f Compare September 18, 2023 11:40
@ShiChangkuo ShiChangkuo merged commit 1463881 into FlexibleEngineCloud:master Sep 18, 2023
4 checks passed
@Zippo-Wang Zippo-Wang deleted the fix_docs_reference_hwcloud branch November 1, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants