Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump deps for @spacehq/storage #74

Closed
wants to merge 1 commit into from
Closed

chore: bump deps for @spacehq/storage #74

wants to merge 1 commit into from

Conversation

talentlessguy
Copy link

Description

This PR updates storage's pkg deps to latest and (possibly) fixes #72

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Dependency upgrade

How Has This Been Tested?

  • Unit Test
  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@talentlessguy
Copy link
Author

looks like there are issues in the source 🤔

Error: src/metadata/gundbMetadataStore.ts(582,11): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
Error: src/userStorage.spec.ts(396,11): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?

@jsonsivar
Copy link
Member

Yeah @talentlessguy , looks like there is an issue with that and I don't think it was there before the upgrade. In order to merge this change you'd have to run the test locally and in order to run the integration tests, the following dependencies are required:

  • Account and API keys with Textile Hub (to be then used as env vars here which you can see in the integration_tests package
  • Deployment of the space-services and then using the vault endpoint and secret in there

Perhaps if you can get all the tests but the integration ones working then we can see in our CI if the integration ones work as well, that's another option).

@talentlessguy talentlessguy closed this by deleting the head repository Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@talentlessguy @jsonsivar