Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative number flag values are set to strings after updating #4197

Closed
1 of 4 tasks
rolodato opened this issue Jun 19, 2024 · 0 comments · Fixed by #4316
Closed
1 of 4 tasks

Negative number flag values are set to strings after updating #4197

rolodato opened this issue Jun 19, 2024 · 0 comments · Fixed by #4316
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

See steps below.

Steps To Reproduce

  1. Create a new feature with a value of -1. Its value will be correctly saved as an integer
  2. Update the feature; erase and type in -1 again, and save
  3. The value will be incorrectly saved as the string "-1"

Expected behavior

Valid integers should always be saved as integers.

Screenshots

negative.integer.mov
@rolodato rolodato added the bug Something isn't working label Jun 19, 2024
@kyle-ssg kyle-ssg linked a pull request Jul 9, 2024 that will close this issue
fix: incorrect negative value conversion #4316
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect negative value conversion Flagsmith/flagsmith
1 participant
@rolodato