From 36ea1ea5a7a5389656f4b89a2eb9f35f0c0d6ae6 Mon Sep 17 00:00:00 2001 From: Gagan Trivedi Date: Thu, 22 Jun 2023 11:19:41 +0530 Subject: [PATCH 1/3] fix(cd): pin flutter version --- .github/workflows/publish_master.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish_master.yml b/.github/workflows/publish_master.yml index 4ed0d30..655b43a 100644 --- a/.github/workflows/publish_master.yml +++ b/.github/workflows/publish_master.yml @@ -8,18 +8,21 @@ jobs: analyze: runs-on: ubuntu-latest name: Dart Analyze - steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: subosito/flutter-action@v2 + with: + flutter-version: '2.x' + channel: 'any' - run: flutter pub get - run: flutter analyze + score: runs-on: ubuntu-latest name: Dart package score steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: axel-op/dart-package-analyzer@v3 with: githubToken: ${{ secrets.GITHUB_TOKEN }} From e67b7135713e3356fc78a47bd85eed343ef42332 Mon Sep 17 00:00:00 2001 From: Gagan Trivedi Date: Thu, 22 Jun 2023 16:14:47 +0530 Subject: [PATCH 2/3] disable score --- .github/workflows/publish_master.yml | 17 +++++++++-------- .github/workflows/pull-request.yml | 20 ++++++++++---------- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/workflows/publish_master.yml b/.github/workflows/publish_master.yml index 655b43a..bf84d41 100644 --- a/.github/workflows/publish_master.yml +++ b/.github/workflows/publish_master.yml @@ -17,15 +17,16 @@ jobs: - run: flutter pub get - run: flutter analyze - score: - runs-on: ubuntu-latest - name: Dart package score + # TODO enable this after upgrading to dart 3.x + # score: + # runs-on: ubuntu-latest + # name: Dart package score - steps: - - uses: actions/checkout@v3 - - uses: axel-op/dart-package-analyzer@v3 - with: - githubToken: ${{ secrets.GITHUB_TOKEN }} + # steps: + # - uses: actions/checkout@v3 + # - uses: axel-op/dart-package-analyzer@v3 + # with: + # githubToken: ${{ secrets.GITHUB_TOKEN }} publishing: runs-on: ubuntu-latest diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 1f2c672..c16de4b 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -35,16 +35,16 @@ jobs: - run: flutter pub get - run: flutter pub test - - score: - runs-on: ubuntu-latest - name: Dart package score - - steps: - - uses: actions/checkout@v3 - - uses: axel-op/dart-package-analyzer@v3 - with: - githubToken: ${{ secrets.GITHUB_TOKEN }} + # TODO enable this after upgrading to dart 3.x + # score: + # runs-on: ubuntu-latest + # name: Dart package score + + # steps: + # - uses: actions/checkout@v3 + # - uses: axel-op/dart-package-analyzer@v3 + # with: + # githubToken: ${{ secrets.GITHUB_TOKEN }} publishing: runs-on: ubuntu-latest From 37dcc1faf08845ad466eb6c7dc46ac9a8cee44f2 Mon Sep 17 00:00:00 2001 From: Gagan Trivedi Date: Thu, 22 Jun 2023 20:07:29 +0530 Subject: [PATCH 3/3] squash! update todo --- .github/workflows/publish_master.yml | 11 +---------- .github/workflows/pull-request.yml | 10 +--------- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/.github/workflows/publish_master.yml b/.github/workflows/publish_master.yml index bf84d41..871d877 100644 --- a/.github/workflows/publish_master.yml +++ b/.github/workflows/publish_master.yml @@ -17,16 +17,7 @@ jobs: - run: flutter pub get - run: flutter analyze - # TODO enable this after upgrading to dart 3.x - # score: - # runs-on: ubuntu-latest - # name: Dart package score - - # steps: - # - uses: actions/checkout@v3 - # - uses: axel-op/dart-package-analyzer@v3 - # with: - # githubToken: ${{ secrets.GITHUB_TOKEN }} + # TODO https://github.com/Flagsmith/flagsmith-flutter-client/issues/57 publishing: runs-on: ubuntu-latest diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c16de4b..48a71e3 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -35,16 +35,8 @@ jobs: - run: flutter pub get - run: flutter pub test - # TODO enable this after upgrading to dart 3.x - # score: - # runs-on: ubuntu-latest - # name: Dart package score - # steps: - # - uses: actions/checkout@v3 - # - uses: axel-op/dart-package-analyzer@v3 - # with: - # githubToken: ${{ secrets.GITHUB_TOKEN }} + # TODO https://github.com/Flagsmith/flagsmith-flutter-client/issues/57 publishing: runs-on: ubuntu-latest