Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed guards spawning every time a player joins. #10

Open
wants to merge 4 commits into
base: rewrite
Choose a base branch
from

Conversation

Switty6
Copy link

@Switty6 Switty6 commented Jan 4, 2020

No description provided.

Copy link
Member

@pongo1231 pongo1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In its current state it'll only run once after 500 ms of waiting. So if there are no players in the server when it runs it won't do anything at all. Also it'll only spawn the guards for the nearest safezone (if there's one) once and never again until either the resource or server restarts.

A better solution to the problem would be to find out what is causing clients to spawn guards again after they've been spawned already and fix the existing system involving entity decorators instead. These will make it easier for clients to communicate about spawned guards than using events.

Does the gamemode consistenly spawn additional guards for each player? Also what happens if a player far away teleports to another player who is very close to a safezone? Does that still spawn additional guards? If not I might have an idea as to why that happens and the existing system isn't able to prevent it from happening.

@Switty6
Copy link
Author

Switty6 commented Jan 5, 2020

I forgot to put it in a loop. Dang it!

The game mode spawns a guard for every player on the server.
Yes, if 2 players are near a safe zone, the guards will still be the same(one for each player). I’ve seen that they are set to spawn for every player host but sadly something goes wrong. I’ll do more research on how this behaves tomorrow and see what causes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants