Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Lodestone-1.20.1-1.6.2.3-fabric #383

Closed
emihead opened this issue Sep 10, 2024 · 1 comment
Closed

Crash with Lodestone-1.20.1-1.6.2.3-fabric #383

emihead opened this issue Sep 10, 2024 · 1 comment

Comments

@emihead
Copy link

emihead commented Sep 10, 2024

Bug Description

LodestarMC/Lodestone#46 (comment)

I opened an issue on Lodestone about this and they apparently removed support for versions of Sodium older than 0.5.9. This combo makes the game crash.
I haven't tested on 1.6.2.3b or c but I can only assume the issue is still there since the changelogs don't mention anything about reverting the Sodium-related changes. Even if they did, it may be worth adding in some compat so Lodestone doesn't have to hold itself back.
Since it's an old Sodium problem I figured it'd be better if I came here about it than kept bugging the Lodestone devs.

Reproduction Steps

  1. install embeddium and lodestone-1.20.1-1.6.2.3-fabric
  2. launch game

Log File

https://mclo.gs/z5ksHqe

@embeddedt
Copy link
Contributor

Lodestone uses a mixin into Embeddium/Sodium internals, which is not guaranteed to work across updates. For what they are trying to do, they should be able to just inject into the vanilla renderChunkLayer function, and not touch Embeddium internals at all. They just need to change their mixin's priority so it doesn't conflict with Embeddium/Sodium.

@embeddedt embeddedt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants