Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow markdown panic guides #9

Open
lucas42 opened this issue Mar 21, 2017 · 2 comments
Open

Allow markdown panic guides #9

lucas42 opened this issue Mar 21, 2017 · 2 comments

Comments

@lucas42
Copy link
Member

lucas42 commented Mar 21, 2017

Currently, go-fthealth expects the panicGuide field to be a URL, but the spec says markdown is supported. We should handle markdown correctly when displaying it to users, rather than treating it as a URL.

Example use case: https://github.com/Financial-Times/coreos-version-checker/blob/master/version.go#L26
@tosan88
Copy link
Contributor

tosan88 commented Dec 4, 2017

Is this still valid or is it resolved as per #10?

@lucas42
Copy link
Member Author

lucas42 commented Dec 4, 2017

No, #10 will show plaintext copy for panic guides, but doesn't handle markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucas42 @tosan88