Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exometer_admin:default/1 prevents creation of custom types #20

Open
uwiger opened this issue Apr 6, 2015 · 0 comments
Open

exometer_admin:default/1 prevents creation of custom types #20

uwiger opened this issue Apr 6, 2015 · 0 comments

Comments

@uwiger
Copy link
Member

uwiger commented Apr 6, 2015

exometer_admin:default(Type) will cause a function_clause exception for any given type not already known to exometer_core. This seems unnecessary.

Fix: have a catch-all clause return undefined. If no module is given for the type, this will cause a follow-on error, which perhaps could be handled in a prettier way.

(Would create a PR directly, but am already messing with exometer_admin for other reasons, so this is a reminder for later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant